Download localized cover for PAL's game is incomplete

[GoogleCodeExporter]

(before to start : sorry for my poor english)

What steps will reproduce the problem?

1. Go to CoverFloader's options and set language to 'FR'
2. Dump a multi-language PAL's game.
3. Download cover with RC9.

What is the expected output? What do you see instead?

Expected : get the french's cover.
Instead I have the english's one.

What version of the product are you using? On what operating system?

CoverFloader RC9 / cIOSrev12

Please provide any additional information below.

I've looked at code source of cover.c :
http://code.google.com/p/wiicoverflow/source/browse/trunk/CoverFlow/source/cover
.c?spec=svn753&r=753

We can see this code :

-----------------------------------------
        switch (id[3]){
                case 'J':
                        sprintf(country, "JA");
                        break;
                case 'K':
                case 'T':
                case 'Q':
                        sprintf(country, "KO");
                        break;
                case 'D':
                        sprintf(country, "DE");
                        break;
                case 'F':
                        sprintf(country, "FR");
                        break;
                case 'P':
                case 'X':
                case 'Y':
                        sprintf(country, "EN");
                        break;
                case 'E':
                        sprintf(country, "US");
                        break;
                default:
                        sprintf(country, "EN");
        }
-----------------------------------------

We can see that contry is set to "EN" where id[3] is 'P'.
'FR' or 'DE' are used only where id[3] is 'F' or 'D'.

But id 'F' or 'D' are only used for ultra-localized game, with a lot of
in-game change...

Most of PAL's game with id[3]=='P' are commons for all european's country
and share the same code. The only difference is the packaging.

For exemple if you see this game : http://wiitdb.com/Game/RENP8P
The unique code RENP8P is used for 5 languages, with 5 differents covers...

PAL's game can contains up to 6 languages : EN, FR, DE, ES, IT and NL.

So for PAL's game (id[3]=='P'), country-code should be determined from the
coverloader's language (with fallback to 'EN').

Original issue reported on code.google.com by frederic...@gmail.com on 5 Jul 2009 at 10:40

[GoogleCodeExporter]

Thanks for clarification.
As for now, the cover is downloaded based only on gameid, but fallback to 
SYSTEM(not
coverfloader) settings is a good intermediate fallback.
I'm italian and my system language is IT, but I prefere coverfloader in english.
I'll add support for that, but need some testing.

1) try to get cover based on ID
2) fall back to system language
3) fall back to english

Original comment by scognito@gmail.com on 5 Jul 2009 at 11:53

• Changed state: Started

[GoogleCodeExporter]

If you need a tester for this, I can do it :D

Original comment by frederic...@gmail.com on 5 Jul 2009 at 12:45

[GoogleCodeExporter]

yeah, I just finished to code it, tell me your mail and I'll send you the build.

Original comment by scognito@gmail.com on 5 Jul 2009 at 12:57

[GoogleCodeExporter]

Fixed in r470

Original comment by scognito@gmail.com on 5 Jul 2009 at 1:30

• Changed state: Fixed

[GoogleCodeExporter]

You can send it to my gmail account ( my login + @gmail.com )

Thanks !

Original comment by frederic...@gmail.com on 5 Jul 2009 at 1:41