tecnalia-advancedmanufacturing-robotics / godel

ROS-Industrial Focused Technical Project: Robotic Blending
2 stars 1 forks source link

Allow path parametrization from gui #3

Closed pdaelm closed 4 years ago

pdaelm commented 4 years ago

Changing parameters through the GUI has no effect on the path generation. Parameters are actually passed through the action server correctly but the blending_service_path_generation code is generating an empty PathPlanningParameters message instead of getting parameter from goal. Can be tested launching the scan and plan application (any robots should be working) and changing path parameters in any of the blend panel.

miguelprada commented 4 years ago

Seems to work in my limited test and CI passes.

The only issue I have with this is that the GUI panels are not populated with the default parameters, so it's a bit difficult to test. This problem is beyond the scope of this PR, though, so I'll merge as is.