search

tecnalia-advancedmanufacturing-robotics / godel

ROS-Industrial Focused Technical Project: Robotic Blending
2 stars 1 forks source link

Replaced keyence ocurrences with quelltech #7

Closed hectorherrero closed 4 years ago

hectorherrero commented 4 years ago

Closes #5

Related https://git.code.tecnalia.com/tecnalia_robotics/rosin/godel_fanuc_config/-/merge_requests/16

godel_fanuc_config branch is required until it merges with the trunk

hectorherrero commented 4 years ago

With the implemented changes in the laser driver (added a simulated behavior) and proper management of sim_laser parameter in the launch file is no longer required the use of https://github.com/tecnalia-advancedmanufacturing-robotics/godel/tree/test-scan-without-real-laser branch for simulating the scanning process.

pdaelm commented 4 years ago

As the fix proposed by @miguelprada in this branch is relative to the scan process execution, I think it would be relevant to include it in this MR. What about cherry picking this commit ?

hectorherrero commented 4 years ago

Totally agree, in fact for testing the whole process appropriately is required.