search

tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.22k stars 1.52k forks source link

lowercase s in function names #462

Closed gemal closed 2 years ago

gemal commented 2 years ago

more fix for #419

codecov-commenter commented 2 years ago

Codecov Report

Merging #462 (5b2cf19) into main (3cfc830) will not change coverage. The diff coverage is 81.04%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files         127      127           
  Lines       23052    23052           
=======================================
  Hits        16769    16769           
  Misses       6283     6283
Flag Coverage Δ
php-5.6-ubuntu-latest 72.42% <81.04%> (ø)
php-7.1-ubuntu-latest 72.81% <81.04%> (ø)
php-7.2-ubuntu-latest 72.68% <81.04%> (-0.01%) :arrow_down:
php-7.3-ubuntu-latest 72.68% <81.04%> (ø)
php-7.4-ubuntu-latest 72.68% <81.04%> (ø)
php-8.0-ubuntu-latest 72.68% <81.04%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tcpdf.php 70.80% <81.04%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cfc830...5b2cf19. Read the comment docs.

williamdes commented 2 years ago

For me this is a BC break, right?

gemal commented 2 years ago

Php functions are case insensitive. So setX and Setx is the same