tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.22k stars 1.52k forks source link

PHP 8.1 fixes and PHP 5.x CI fix #463

Closed williamdes closed 2 years ago

williamdes commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Merging #463 (c9a821d) into main (a5b2fdb) will decrease coverage by 0.00%. The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   72.74%   72.73%   -0.01%     
==========================================
  Files         127      127              
  Lines       23052    23051       -1     
==========================================
- Hits        16769    16767       -2     
- Misses       6283     6284       +1     
Flag Coverage Δ
php-5.3-ubuntu-latest 72.37% <81.81%> (?)
php-5.4-ubuntu-latest 72.37% <81.81%> (?)
php-5.5-ubuntu-latest 72.37% <81.81%> (?)
php-5.6-ubuntu-latest ?
php-7.1-ubuntu-latest ?
php-7.2-ubuntu-latest ?
php-7.3-ubuntu-latest 72.68% <90.90%> (+<0.01%) :arrow_up:
php-7.4-ubuntu-latest ?
php-8.0-ubuntu-latest 72.68% <90.90%> (-0.01%) :arrow_down:
php-nightly-ubuntu-latest 72.65% <90.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/example_050.php 100.00% <ø> (ø)
tcpdf_barcodes_1d.php 89.53% <0.00%> (-0.02%) :arrow_down:
tcpdf_barcodes_2d.php 62.98% <0.00%> (ø)
examples/example_012.php 100.00% <100.00%> (ø)
examples/tcpdf_include.php 100.00% <100.00%> (ø)
include/tcpdf_static.php 53.03% <100.00%> (-0.20%) :arrow_down:
tcpdf.php 70.84% <100.00%> (+0.03%) :arrow_up:
include/tcpdf_fonts.php 44.38% <0.00%> (-0.26%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5b2fdb...c9a821d. Read the comment docs.

williamdes commented 2 years ago

@nicolaasuni could you help my by reviewing and releasing this PHP 8.1 bunch of fixes ? I have to post this quickly on Debian: https://tracker.debian.org/pkg/tcpdf

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

williamdes commented 2 years ago

Thank you so much!!!