I want to show a generated document in-line, but keep German umlaut (Ä, Ö, Ü ...) in the suggested file name.
In the Output() method there is an if-statement where in non-"F*"-mode (which actually are in-line "I" and download "D" modes) all kind of special characters are removed.
My class inherits from TCPDF, but I don't want to overwrite the complete Output() method.
Wouldn't it make more sense to outsource the file name sanitization into a separate method?
What are the chances that a pull request with such a modification will be accepted?
Hi,
I want to show a generated document in-line, but keep German umlaut (Ä, Ö, Ü ...) in the suggested file name. In the Output() method there is an if-statement where in non-"F*"-mode (which actually are in-line "I" and download "D" modes) all kind of special characters are removed. My class inherits from TCPDF, but I don't want to overwrite the complete Output() method. Wouldn't it make more sense to outsource the file name sanitization into a separate method? What are the chances that a pull request with such a modification will be accepted?
Thx in advance