CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: nicolaasuni
:x: KevinVG
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e8a76e1). Click here to learn what that means. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage        ?   72.79%           
=======================================
  Files           ?      127           
  Lines           ?    21610           
  Branches        ?        0           
=======================================
  Hits            ?    15731           
  Misses          ?     5879           
  Partials        ?        0

Flag	Coverage Δ
php-8.1-ubuntu-latest	`72.79% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/tcpdf_fonts.php	`43.62% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nicolaasuni commented 1 year ago

@KevinVG please sign the license/cla to be able to merge this.

nicolaasuni commented 1 year ago

Closing this as CLS was not signed and the issue was solved by: https://github.com/tecnickcom/TCPDF/commit/e3d45a685352419e02a757f729f3ee153ccf217c

tecnickcom / TCPDF

Bug fix: returning false #517

Codecov Report