search

tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.22k stars 1.52k forks source link

Output error #518

Closed BondorD closed 1 year ago

BondorD commented 2 years ago

Output(,'F') error and how I managed to fix it

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

littlepackage commented 2 years ago

Curious, why throw baby out with the bathwater? This method will throw errors in certain instances. What was your error? Have you confirmed the file in question is actually in the location and accessible (e.g. not blocked by something like PrivateTmp)? Could you provide more background as to why you suggest these changes?

DuckDensity commented 2 years ago

I ended up making the same edit during development.

When running on the command line (in Windows environment) and executing a php script stored on a network device using a UNC path, this code prevents the generated PDF file from being saved to the same folder system. A work around is to use a mapped drive letter, rather than UNC Path.

This error is: Warning: fopen(file://\\Server\Share\Path\File ....) Failed to open stream

Not too sure of the security implications here, but when working on CLI with a known file system it should be safe to save? Perhaps this function needs to behave differently for CLI compared to web server environment?

nicolaasuni commented 1 year ago

The removed section is there for security reasons, so I can't merge this.