bayramarslan commented 2 years ago

FIXES #489

nicolaasuni commented 2 years ago

The barcode methods in this library are obsolete and unmaintained. Please use instead tc-lib-barcode.

nicolaasuni commented 2 years ago

The scale parameter was added in PHP 7.2 and this change will break backward compatibility. TCPDF is compatible with PHP 5.3.0

nicolaasuni commented 1 year ago

@bayramarslan please sign the license/cla to merge this.

codecov-commenter commented 1 year ago

Codecov Report

Merging #534 (3458b84) into main (29c3748) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   72.98%   72.98%           
=======================================
  Files         128      128           
  Lines       23113    23113           
=======================================
+ Hits        16868    16870    +2     
+ Misses       6245     6243    -2

Flag	Coverage Δ
php-5.3-ubuntu-latest	`72.48% <0.00%> (?)`
php-5.4-ubuntu-latest	`?`
php-5.5-ubuntu-latest	`72.48% <0.00%> (?)`
php-5.6-ubuntu-latest	`72.52% <0.00%> (?)`
php-7.1-ubuntu-latest	`72.91% <0.00%> (-0.01%)`	:arrow_down:
php-7.2-ubuntu-latest	`72.79% <0.00%> (-0.01%)`	:arrow_down:
php-7.3-ubuntu-latest	`72.79% <0.00%> (ø)`
php-7.4-ubuntu-latest	`72.79% <0.00%> (-0.01%)`	:arrow_down:
php-8.0-ubuntu-latest	`72.80% <0.00%> (ø)`
php-8.1-ubuntu-latest	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/barcodes/pdf417.php	`60.72% <0.00%> (ø)`
tcpdf.php	`71.14% <0.00%> (+0.01%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tecnickcom / TCPDF

FIX: PDF417 corrupt output problem, solution set bcmath scale parameter to zero #534

Codecov Report