tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.18k stars 1.51k forks source link

Project maintenance #537

Open theofidry opened 2 years ago

theofidry commented 2 years ago

Hi @nicolaasuni,

I was wondering if you would consider adding new maintainers to the project. I think a few people are looking to help, e.g. @mvorisek and @williamdes were a bit active last year and I think in general there is quite a few attempts at contributing. I would also be happy to help: I have little personal time for it but since my company is using it I can allocate some time for at the very least helping with the reviews & merging.

I however understand it's not an easy decision, and there is always the fear of the new maintainers going in a very different direction, messing things up, being too aggressive with refactorings or migrating etc. If this is the case, I would highly recommend the approach adopted by @\fzaninotto for https://github.com/fzaninotto/Faker or myself for https://github.com/humbug/humbug which is archiving the project and pointing to an alternative, which could also be a fork.

This package can boast of a 35k daily download and is definitely one if not the most popular PDF generator in the PHP community. I do use it for a couple of professional projects as well and personally I would love to see it be active again one way or another and propose changes to come back more in line with modern PHP whilst providing an acceptable migration path and BC compatibility as much as possible given its wide usage.

williamdes commented 2 years ago

would consider adding new maintainers to the project. I think a few people are looking to help, e.g. @mvorisek and @williamdes were a bit active last year and I think in general there is quite a few attempts at contributing.

I am willing to continue my daily issue review and PR reviews I would definitely need some communication from the project owner I had started a fork as some users have done, just to merge bug fixes and have them in production

This project is so huge and used everywhere it is critical it stays maintained as long as possible But without communication it will take another path some day and I really do not know what to expect We use it at work, some laravel libs use it And at @phpmyadmin we use it I even do the Debian/Ubuntu packaging for tcpdf: https://tracker.debian.org/pkg/tcpdf

So please @nicolaasuni give us some hope 🙏🏻 We can invest time to keep this afloat

williamdes commented 2 years ago

Ref https://github.com/code-lts/WarnockPDF/discussions/1#discussioncomment-537344

managerrojo commented 2 years ago

hi guys im working in a project that use it this Library and in the error Log show me:

Array and string offset access syntax with curly braces is no longer supported in /var/www/html/vendor/rafikhaceb/tcpdi/tcpdi_parser.php on line 818

818 : $frag = $data{$offset} . @$data{$offset+1} . @$data{$offset+2} . @$data{$offset+3};

since this way is deprecate after 7.4 a this new way :

818 : $frag = $data[$offset] . @$data[$offset+1] . @$data[$offset+2] . @$data[$offset+3];

I would like. help to update this project or I recommend use rector for Update it the a simple easy way and almost automatically

ro0NL commented 2 years ago

I would definitely need some communication from the project owner

cc @nicolaasuni @tecnickcom once more :)

my question is do PRs get merged still?

ro0NL commented 2 years ago

info@tecnick.com is not responding, i'd do the fork :smiling_imp: and move on.

williamdes commented 2 years ago

info@tecnick.com is not responding, i'd do the fork smiling_imp and move on.

Seems like it was taken in account, PRs where merged and a version was released ! See: https://github.com/tecnickcom/TCPDF/releases/tag/6.5.0

ro0NL commented 2 years ago

did not expect those odds :D but that's good news then :+1: