tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.18k stars 1.51k forks source link

Fix TypeError: count() in PHP8 #556

Closed NiklasBr closed 1 year ago

NiklasBr commented 1 year ago

Resolves #555

mazuk6 commented 1 year ago

I think it will close this one as well.. https://github.com/tecnickcom/TCPDF/issues/526

williamdes commented 1 year ago

Can you add one example in the examples folder with the code that created this error? This will help cover your fix

codecov-commenter commented 1 year ago

Codecov Report

Merging #556 (bf2e8b5) into main (6da8a0f) will increase coverage by 0.12%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   72.86%   72.99%   +0.12%     
==========================================
  Files         127      127              
  Lines       21666    21673       +7     
==========================================
+ Hits        15787    15820      +33     
+ Misses       5879     5853      -26     
Flag Coverage Δ
php-7.1-ubuntu-latest 72.92% <100.00%> (?)
php-7.3-ubuntu-latest ?
php-7.4-ubuntu-latest ?
php-8.1-ubuntu-latest ?
php-nightly-ubuntu-latest 72.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tcpdf.php 71.65% <100.00%> (+0.16%) :arrow_up:
tcpdf_barcodes_1d.php 87.37% <0.00%> (ø)
examples/example_003.php 100.00% <0.00%> (ø)
examples/example_010.php 100.00% <0.00%> (ø)
examples/example_011.php 100.00% <0.00%> (ø)
examples/example_051.php 100.00% <0.00%> (ø)
examples/example_059.php 100.00% <0.00%> (ø)
examples/example_020.php 96.00% <0.00%> (+0.08%) :arrow_up:
include/tcpdf_static.php 52.97% <0.00%> (+0.20%) :arrow_up:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nicolaasuni commented 1 year ago

In order to be able to merge this the license/cla must be signed.

NiklasBr commented 1 year ago

I can't see the CLA link which usually accompanies those PR:s.