tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.22k stars 1.52k forks source link

Extract method to get TCPDF producer #572

Closed MauricioFauth closed 1 year ago

MauricioFauth commented 1 year ago

Wraps TCPDF_STATIC::getTCPDFProducer() calls with a private method and adds an empty private property that can be used to change the producer line. The private property can be changed with the reflection API.

Both method and property are declared as private to avoid BC breaks.

The idea is to help with testing PDF generation, by using a predictable producer line.

codecov-commenter commented 1 year ago

Codecov Report

Merging #572 (d936d51) into main (2fb1c01) will decrease coverage by 0.01%. The diff coverage is 57.14%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   69.33%   69.32%   -0.01%     
==========================================
  Files         128      128              
  Lines       27022    27027       +5     
==========================================
+ Hits        18735    18737       +2     
- Misses       8287     8290       +3     
Flag Coverage Δ
php-5.3-ubuntu-latest ?
php-5.4-ubuntu-latest 68.84% <57.14%> (-0.01%) :arrow_down:
php-5.5-ubuntu-latest ?
php-5.6-ubuntu-latest 68.91% <57.14%> (-0.01%) :arrow_down:
php-7.0-ubuntu-latest 71.58% <66.66%> (-0.01%) :arrow_down:
php-7.1-ubuntu-latest 73.06% <80.00%> (-0.01%) :arrow_down:
php-7.2-ubuntu-latest 72.94% <80.00%> (-0.01%) :arrow_down:
php-7.3-ubuntu-latest ?
php-7.4-ubuntu-latest ?
php-8.0-ubuntu-latest ?
php-8.1-ubuntu-latest 72.94% <80.00%> (-0.01%) :arrow_down:
php-8.2-ubuntu-latest ?
php-nightly-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tcpdf.php 67.89% <57.14%> (-0.01%) :arrow_down:

... and 1 file with indirect coverage changes

williamdes commented 1 year ago

@nicolaasuni could you review this one please ?

nicolaasuni commented 1 year ago

The producer line is intentionally hardcoded. New features like this one could be considered for the new tc-lib-pdf project.