search

tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.18k stars 1.51k forks source link

Fix: #553 #601

Open lpetrora opened 1 year ago

lpetrora commented 1 year ago

Fix: #553

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Leonardo Petrora seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

lpetrora commented 1 year ago

I have already signed the CLA but the status is still pending. I tried to recheck but there is no change

williamdes commented 1 year ago

Please edit the description to use Fixes: #553 or Fix: #553

THenkeDE commented 1 year ago

to bypass this you have to add a helper variable like

            $gdfunction = 'imagecreatefrom'.$type;
            $silenceGdfunction = $type === 'png';
            ...
                    // GD library
                    $img = $silenceGdfunction ? @$gdfunction($file) : $gdfunction($file);

but i have no idea if silencing a method was, is oder ever will be a good decision.