search

tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.18k stars 1.51k forks source link

Fixed problems with S25 barcode #611

Closed theonlytruth closed 1 year ago

theonlytruth commented 1 year ago

Using your S25 barcode generator I found a problem. The representation of the digit 8 was the same as 0. I fixed it. Now it is recognized correctly.

Additionally you were using different bar widths for the start and stop values. I changed this too.

One thing I did not change till now is the part where you add an leading 0 if the string is odd. Why do you do so? I can't find anything that S25 has to be even. Maybe you mixed it up with interleaved 2 of 5 bar code where you need the even number because the digits are represented from pairs of bars and whitespaces?

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

nicolaasuni commented 1 year ago

Can you please check/use the https://github.com/tecnickcom/tc-lib-barcode instead?

theonlytruth commented 1 year ago

Can you please check/use the https://github.com/tecnickcom/tc-lib-barcode instead?

I checked it and if I'm not wrong S25 is not implemented yet. No code in the formatCode function.