search

tecnickcom / TCPDF

Official clone of PHP library to generate PDF documents and barcodes
https://tcpdf.org
Other
4.21k stars 1.52k forks source link

missing Documentation on K_ALLOWED_TCPDF_TAGS #716

Open THenkeDE opened 6 months ago

THenkeDE commented 6 months ago

With the breaking change of 6.7.4 (2024-03-24) the K_ALLOWED_TCPDF_TAGS definition has beein added, too and changelog is saying:

New K_ALLOWED_TCPDF_TAGS configuration constant to set the allowed methods for the tcdpf HTML tag.

Well, even the example_049.php beeing referenced in the changelog is not making use of this and the Tag is not working in any way because the default does not allow any method:

if (!defined('K_ALLOWED_TCPDF_TAGS')) {
    define('K_ALLOWED_TCPDF_TAGS', '');
}

Maybe it is just me but have you checked the example prior publishing? This hard to find "bug" gave me headaches ...

d-javu commented 6 months ago

The alternative configuration file offer this:

https://github.com/tecnickcom/TCPDF/blob/82fc97bf1c74c8dbe62b1d3cc6d10fa4b87e0262/examples/config/tcpdf_config_alt.php#L215-L221

THenkeDE commented 6 months ago

well yes, i should have mentioned that i looked it up, too.

But i still think that an example that shows how a "BREAKING CHANGE" should be used should not rely on a slightly "hidden" configuration override.

A note inside the example with a reference to the tcpdf_config_alt.php configline would've done the job.

Configurations of such a major change should not be hidden under the radar like this.

Anyhow, thanks for reply and reminding myself of beeing a little more into detail.