Some methods could probably better be static

tecnickcom / tc-lib-color

PHP library to manipulate various color representations

Other

23 stars 6 forks source link

Some methods could probably better be static #6

Closed micschk closed 7 years ago

micschk commented 7 years ago

For exampe:

Web::getClosestWebColor
Web::getNameFromHex
Web::extractHexCode
...

Actually, all of the methods in Web seem to be working with arguments, none of them depend on an instantiated object ($this)?

nicolaasuni commented 7 years ago

Generally speaking, static methods break a lot of the power available to Object-Oriented code and make harder to perform unit testing. A lot has been written on this subject, a web search should give you more details ...