search

tecoholic / ner-annotator

Named Entity Recognition (NER) Annotation tool for SpaCy. Generates Traning Data as a JSON which can be readily used.
https://tecoholic.github.io/ner-annotator/
MIT License
550 stars 163 forks source link

Migrate from webpack to vite #122

Open kurt-mueller-osumc opened 1 week ago

kurt-mueller-osumc commented 1 week ago

This pull requests updates dependencies as well as migrates from Webpack to ViteJS.

tecoholic commented 1 week ago

@kurt-mueller-osumc Dear lord! Did you actually manage to pull this off? This is amazing. I have tried and given up at least 3 times. I have approved the CI run. Let's see if everything passes. :crossed_fingers:

kurt-mueller-osumc commented 1 week ago

Hi @tecoholic, I didn't update the tests... but I have an instance of your app with vite, standing up in my Azure cloud. I'll see if I can't get tests passing in the next day or so.

tecoholic commented 1 week ago

@kurt-mueller-osumc Thank you. I would also try to get a local build working and test the desktop version this week to verify everything is working. This is truly amazing work.

tecoholic commented 6 days ago

@kurt-mueller-osumc What's the node version used for this upgrade? Can you add the versions of NodeJS and Yarn versions used for this in the PR description?

I was able to get a build to work with Node@20 and Yarn@1

image

However, the interface was broken and there are plenty of warnings in the terminal as well. So I am worried things might be broken.

kurt-mueller-osumc commented 2 days ago

However, the interface was broken and there are plenty of warnings in the terminal as well. So I am worried things might be broken.

My apologies for the delay in response. I was on vacation :)

When you say the interface, are you talking about javascript assets or image assets?

I've been using the latest version of yarn and node v21.