search

tecoholic / ner-annotator

Named Entity Recognition (NER) Annotation tool for SpaCy. Generates Traning Data as a JSON which can be readily used.
https://tecoholic.github.io/ner-annotator/
MIT License
548 stars 161 forks source link

Bug fixes #61

Closed alvi-khan closed 1 year ago

alvi-khan commented 1 year ago

Fixes #58, #59 and #60.

For #59, the tagging progress indicator on the left sidebar remains incomplete on the last sentence. Left this as is on purpose since saving or skipping on the last sentence leaves the user on that sentence. Leaving it up to @tecoholic to decide how they want to handle the UX for that.

tecoholic commented 1 year ago

@alvi-khan Wow. Thank you for taking the time to identify and fix the bugs. I will try to review them this weekend and get them merged.

tecoholic commented 1 year ago

@alvi-khan I cannot pull your changes to my local machine for testing. And your repo's URL https://github.com/alvi-khan/ner-annotator returns a 404. Do you by any chance have the repo marked private?

alvi-khan commented 1 year ago

@tecoholic Sorry about that. I've been having some synchronization issues with my local repo. Could you check again please when you have the time?

tecoholic commented 1 year ago

@alvi-khan Thanks for getting this sorted out. I will review and merge the PRs when I get some free time this week.

alvi-khan commented 1 year ago

Added fix for #65.

alvi-khan commented 1 year ago

@tecoholic please add a proxy approval here as well. TIA.

alvi-khan commented 1 year ago

Addressed in #70.