tecosaur / LaTeX-auto-activating-snippets

Mirror of https://git.tecosaur.net/tec/LaTeX-auto-activating-snippets
GNU General Public License v3.0
100 stars 24 forks source link

Add support for markdown-mode #25

Open maikol-solis opened 2 years ago

maikol-solis commented 2 years ago

Hi!

As a naïve way to make laas to work with markdown-mode I modify the laas-mathp function (https://github.com/tecosaur/LaTeX-auto-activating-snippets/blob/master/laas.el#L60) to use laas-org-mathp to know if we are in a latex block in Markdown documents.

(defun laas-mathp ()
  "Determine whether point is within a LaTeX maths block."
  (cond
   ((derived-mode-p 'latex-mode) (texmathp))
   ((derived-mode-p 'org-mode) (laas-org-mathp))
   ((derived-mode-p 'markdown-mode) (laas-org-mathp))
   (t (message "LaTeX-auto-activated snippets does not currently support math in any of %s"
               (aas--modes-to-activate major-mode))
      nil)))

At least in my tests, everything is working fine. I can trigger all the snippets without problems.

I don't know if it's worth it to add it in into master.

Thanks.

ymarco commented 2 years ago

(Sorry for late response) What? laas-org-mathp is defined with the org-element api, right? How the hell does this work in markdown? Maybe texmathp would work in markdown, I'm not familiar with whether markdown allows things like straight up \begin{align} blocks, but laas-org-mathp?