search

tecosaur / lexic

Mirror of https://git.tecosaur.net/tec/lexic
GNU General Public License v3.0
78 stars 10 forks source link

lexic-mode-process and sdcv is not killed when lexic buffer is closed #24

Open minad opened 3 years ago

minad commented 3 years ago

As soon as the user-visible lexic UI is terminated, all associated background processes should be terminated. Is there a reason why one needs a lexic-mode-process buffer btw? Is this the stderr buffer?

tecosaur commented 3 years ago

Are you sure the process isn't killed? It is for me. How are you closing the buffer? I've implemented the process-killing by adding it to the quit function bound to q, but maybe there's a hook which would be worth using here too.

minad commented 3 years ago

I close it with kill-buffer, maybe also via an Embark action. It would be better to use a hook to detect when the buffer is killed and then terminate the associated process buffer too.

tecosaur commented 3 years ago

I'll just add to buffer-kill-hook

minad commented 2 years ago

Ping :)

tecosaur commented 2 years ago

Ah yes! I completely forgot about this (as you may have guessed 😅). Pushed in 6301a5ad00cf8eb74e7a522c84c7ccabbec16241.

minad commented 2 years ago

Thanks! It works. One small detail remains - you could also kill the lexic process buffer such that no stale buffers stay around.