search

tectiv3 / react-native-aes

Native module for AES encryption
MIT License
188 stars 135 forks source link

Fix: update podspec to retrieve source via git tag #55

Closed DioneJM closed 2 years ago

DioneJM commented 3 years ago

The source in the .podspec file is pointing to the latest commits instead of the commit specific to the version.. This change adds the tag of the release to make the source more specific.

How to verify:

  1. Create a new project with an older version of the package (e.g. 1.3.8) and use either Aes.encrypt or Aes.decrypt with only the 3 arguments that was previously required (as shown in README)
  2. Add the pod to the project's podspec: 
    pod 'react-native-app-auth', :podspec => '../node_modules/react-native-app-auth/react-native-app-auth.podspec'
  3. pod install
  4. Verify the following error shows up: image
  5. Apply suggested changes
  6. Ensure error no longer occurs