Open CraftSpider opened 8 months ago
Attention: Patch coverage is 55.30393%
with 750 lines
in your changes missing coverage. Please review.
Project coverage is 46.16%. Comparing base (
34d643f
) to head (2617e26
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Created a new branch off this to play around with an idea I've had that will probably not be part of this PR (which I'm hoping to get merged after I fix up the test I broke) - take a look at https://github.com/CraftSpider/tectonic/commit/75f5c9656efd8f9df6be749202bd9fa644115fa5 on my bibtex-parsing branch for a new way to parse things. It manages to separate out aux parsing into two parts, just parsing the line, then emitting warnings and making state changes. The parsing part is entirely separate from state, and as such, can now be unit-tested quite easily.
Best reviewed commit-by-commit if you're looking to understand every change.
This work, so far:
Vec
instead of a custom buffer type everywherelookup_str
is defined - it's primarily about the hash, only tangentially touching the pool.