tectonic-typesetting / tectonic

A modernized, complete, self-contained TeX/LaTeX engine, powered by XeTeX and TeXLive.
https://tectonic-typesetting.github.io/
Other
3.99k stars 162 forks source link

Fix build for rust 1.80 by bumping `time` crates #1209

Closed bryango closed 3 months ago

bryango commented 3 months ago

Fixes #1207. The build fails with rust 1.80 due to an outdated time crate. This can be simply fixed by cargo update time.

This issue would soon affect all downstream (distro) packagers, and the fix is rather trivial and minimal, so I hope it can be fast-tracked into master (after CI of course). A bugfix release would be even better, but it's your decision! @CraftSpider @rm-dr

See:

CraftSpider commented 3 months ago

I just merged #1202, which should fix the unrelated build and clippy failures

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.92%. Comparing base (19654bf) to head (6ade679). Report is 14 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1209 +/- ## ========================================== - Coverage 46.99% 46.92% -0.07% ========================================== Files 176 177 +1 Lines 65196 65160 -36 ========================================== - Hits 30639 30578 -61 - Misses 34557 34582 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bryango commented 3 months ago

Ah thank you very much! This seems to have the working time crate now. Would you be interested in a minor bugfix release? Maybe we shall ping @pkgw?

CraftSpider commented 3 months ago

pkgw would be the right person, I personally don't know the release process yet.

bryango commented 3 months ago

The relevant fix is now available in master at 6b49ca8db40aaca29cb375ce75add3e575558375. Before a proper release @pkgw , downstream may simply cherry-pick this commit. I have checked that it applies nicely on top of https://github.com/tectonic-typesetting/tectonic/tree/tectonic%400.15.0

pkgw commented 3 months ago

Sorry for being completely AWOL on all this :frowning_face:

I'll make a release soon, and make a video explaining the process. With the release automation tools that we have, it can be quite straightforward, although there are a few concepts to learn.