search

tectonic-typesetting / tectonic

A modernized, complete, self-contained TeX/LaTeX engine, powered by XeTeX and TeXLive.
https://tectonic-typesetting.github.io/
Other
3.99k stars 162 forks source link

Bundle rework #1218

Closed rm-dr closed 2 months ago

rm-dr commented 2 months ago

Re-opening PR, original (#1121) was deleted by branch cleanup.

Our current bundle scheme is causing quite a few bugs. This PR (paired with https://github.com/tectonic-typesetting/tectonic-texlive-bundles/pull/14) resolves many of these by implementing proper search paths in bundles.

These changes are not be breaking. Zip and tar bundles may still be used, but they can no longer be created.

Changes in this PR:

Most changes in this PR are in the bundles crate. Changes in other files are usually minor api side-effects.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 22.42249% with 1076 lines in your changes missing coverage. Please review.

Project coverage is 46.20%. Comparing base (ac15f72) to head (a5e3416). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...in/tectonic/v2cli/commands/bundle/select/picker.rs 0.00% 292 Missing :warning:
crates/bundles/src/ttb.rs 0.00% 137 Missing :warning:
crates/bundles/src/ttb_net.rs 0.00% 108 Missing :warning:
...in/tectonic/v2cli/commands/bundle/pack/bundlev1.rs 0.00% 102 Missing :warning:
src/bin/tectonic/v2cli/commands/bundle/actions.rs 0.00% 74 Missing :warning:
crates/bundles/src/ttb_fs.rs 0.00% 62 Missing :warning:
crates/bundles/src/cache.rs 69.34% 42 Missing :warning:
crates/bundles/src/itar.rs 72.09% 36 Missing :warning:
...tectonic/v2cli/commands/bundle/select/input/tar.rs 0.00% 35 Missing :warning:
.../bin/tectonic/v2cli/commands/bundle/select/spec.rs 0.00% 29 Missing :warning:
... and 16 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1218 +/- ## ========================================== - Coverage 46.95% 46.20% -0.75% ========================================== Files 177 188 +11 Lines 65197 66146 +949 ========================================== - Hits 30613 30564 -49 - Misses 34584 35582 +998 ``` | [Flag](https://app.codecov.io/gh/tectonic-typesetting/tectonic/pull/1218/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tectonic-typesetting) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/tectonic-typesetting/tectonic/pull/1218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tectonic-typesetting) | `46.20% <22.42%> (-0.75%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tectonic-typesetting#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.