tectoy / wifiremote

Automatically exported from code.google.com/p/wifiremote
0 stars 0 forks source link

Play TV series episode command #75

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Add a command to play an episode of a tv series.

The user needs to supply:
- Series name or id
- Season number
- Episode number

Series names should be resolved to IDs like they are for movie names in moving 
pictures.

Look at the trakt plugin for reference: 
https://github.com/Technicolour/Trakt-for-Mediaportal/blob/master/TraktPlugin/Tr
aktHandlers/TVSeries.cs#L349

Original issue reported on code.google.com by shuku...@gmail.com on 12 Oct 2011 at 1:03

GoogleCodeExporter commented 8 years ago
Comitted: http://code.google.com/p/wifiremote/source/detail?r=145
Can someone please verify?

Original comment by shuku...@gmail.com on 12 Oct 2011 at 6:58

GoogleCodeExporter commented 8 years ago
I will take a look at this tomorrow.  If possible I'd also like to have a 
command to browse to different MP-TV series views, instead of going directly to 
the actual video.

Original comment by jitterja...@gmail.com on 13 Oct 2011 at 3:48

GoogleCodeExporter commented 8 years ago
Were you able to test the "play tv show" commands? I would publish an updated 
version today if everything is working.

Original comment by shuku...@gmail.com on 16 Oct 2011 at 9:25

GoogleCodeExporter commented 8 years ago
Today!  I did not get a notification of your last comment and I didn't know you 
were waiting for me.

By the way I am working on a German version of VoxCommando for MediaPortal with 
the help of Kalle (i.e. he did all the translation :)

Are you interested in testing it?

The big problem with not using an English speech engine is that recognition of 
English titles (which I think most of us have regardless of where we live) will 
not be very good.  Still for testing, you should be able to play around with 
the German version a bit.

Original comment by jitterja...@gmail.com on 18 Oct 2011 at 12:25

GoogleCodeExporter commented 8 years ago
Hey James,

yes I would be happy to test a German version! My Win7 professional won't let 
me install the english speech engine, so I don't really have an alternative :-/

Original comment by shuku...@gmail.com on 18 Oct 2011 at 3:37

GoogleCodeExporter commented 8 years ago
I tested the play next unwatched episode command and it sees to work, but there 
is some kind of bug.  Did you test this yourself yet?
The episode starts to play but but there is a progress bar at the bottom that I 
can't seem to get rid of without stopping playback (escape doesn't work).

Also, if you try to play something that has been partially viewed a dialog 
comes up asking if you would like to resume or restart from the beginning.  
This is normal, except that it does not respond to Left, Right, or OK commands 
from wifiRemote  and I have to use a mouse or keyboard.  I'm not sure if this 
behaviour is restricted to video that is requested this way, or if this dialog 
ignores wifiremote in general.

I would still appreciate if you could package an mpe1 of the current state of 
the plugin, or tell me how to make one. 

Original comment by jitterja...@gmail.com on 19 Oct 2011 at 1:07

GoogleCodeExporter commented 8 years ago
for the heck of it I added a line (player = null;) to the PlayEpisode method, 
and that got rid of the progress bar, but the problem with the "resume or 
restart" persists.

private static void PlayEpisode(DBEpisode episode)
        {
            if (player == null) player = new VideoHandler();
            player.ResumeOrPlay(episode);
            player = null;
        }

Original comment by jitterja...@gmail.com on 19 Oct 2011 at 1:45

GoogleCodeExporter commented 8 years ago
your code is stopping and waiting for a response from the call to 
player.ResumeOrPlay(episode);

it doesn't get one until after the user decides to resume or restart, which 
means that wifiremote is basically hung until that happens.

I tried to create a new thread to call player.ResumeOrPlay(episode);
this solved the problem of wifiremote not allowing us to respond to the dialog, 
but for some reason it brought back the progress bar, and calling player=null 
no longer gets rid of it.  now I'm kind of stumped.  it would help to know why 
the progress bar is appearing in the first place.  This seems like a TVSERIES 
bug to me.

Original comment by jitterja...@gmail.com on 19 Oct 2011 at 2:34

GoogleCodeExporter commented 8 years ago
That is good information, thanks. 
I want to clean that up and try to add a few things DieBagger suggested, then 
push the next release including an installer.

Original comment by shuku...@gmail.com on 19 Oct 2011 at 8:55

GoogleCodeExporter commented 8 years ago
If there is anyway to jump to a TV show for browsing that would be ideal.  I'm 
not very happy with my current hack.

Original comment by jitterja...@gmail.com on 19 Oct 2011 at 9:18

GoogleCodeExporter commented 8 years ago
We should probably start videos from the ui thread (see the play tv channel 
command). I already had a few crashes when starting tv episodes and in the logs 
I got:

2011-10-21 01:31:11.406486 [ERROR][(35)]: VMR9: Dispose() from wrong thread
2011-10-21 01:31:28.362456 [ERROR][MPMain(1)]: VMR9: Dispose() from wrong thread

Original comment by bgmei...@gmail.com on 21 Oct 2011 at 1:15

GoogleCodeExporter commented 8 years ago
Will do that tonight. Should also be necessary for moving pictures, right?

bgmeiner, can you please open issues for the features you mentioned on irc the 
other night?

Original comment by shuku...@gmail.com on 21 Oct 2011 at 7:55

GoogleCodeExporter commented 8 years ago
Added play on seperate thread. Works fine here and I see no progress bar ... 
maybe a skin issue?

Original comment by shuku...@gmail.com on 21 Oct 2011 at 11:35

GoogleCodeExporter commented 8 years ago
I'm just using the default wide skin.  Can you send me a dll that I can test?

Original comment by jitterja...@gmail.com on 21 Oct 2011 at 11:56

GoogleCodeExporter commented 8 years ago
http://dl.dropbox.com/u/3996208/WifiRemote/WifiRemote_TVSMT.zip

Original comment by shuku...@gmail.com on 22 Oct 2011 at 10:10

GoogleCodeExporter commented 8 years ago
thanks.  I've still got the progress bar issue.

Original comment by jitterja...@gmail.com on 22 Oct 2011 at 2:05

GoogleCodeExporter commented 8 years ago
I've tested this on two computers both do the exact same thing.

I'm using MP 1.2.1.0
I'm using MpTvSeries plugin version: 3.1.1.1864

both test systems are using Win7 Ultimate, one is 32bit one is 64bit.

Original comment by jitterja...@gmail.com on 22 Oct 2011 at 2:15

GoogleCodeExporter commented 8 years ago
Also tried with default wide now, but no progress bar :-/ 
Must be something special with your MediaPortal installation, I guess.

Will try to tackle the "play season" issue and then publish a new version, if 
nothing else comes up.

Original comment by shuku...@gmail.com on 23 Oct 2011 at 4:11

GoogleCodeExporter commented 8 years ago
"Must be something special with your MediaPortal installation, I guess."

something special on my two separate installations on two separate machines...
is there someone else that can test this?

Original comment by jitterja...@gmail.com on 23 Oct 2011 at 4:23

GoogleCodeExporter commented 8 years ago
...unless it has something to do with the way VoxCommando is calling the 
command.  How are you testing it?  with couch potato?  the c# client?

Original comment by jitterja...@gmail.com on 23 Oct 2011 at 4:25

GoogleCodeExporter commented 8 years ago
I can test it tomorrow... 

Original comment by bgmei...@gmail.com on 23 Oct 2011 at 6:46

GoogleCodeExporter commented 8 years ago
should be fixed now...

Original comment by bgmei...@gmail.com on 24 Oct 2011 at 12:53

GoogleCodeExporter commented 8 years ago
sweet!  works great.

Original comment by jitterja...@gmail.com on 24 Oct 2011 at 1:07

GoogleCodeExporter commented 8 years ago
everything seems to be working well.  Are you going to make a release soon?

Original comment by jitterja...@gmail.com on 27 Oct 2011 at 8:05

GoogleCodeExporter commented 8 years ago
Yes, one more issue has come up (interaction with mp-extended) that we want to 
squeeze in this version. bgmeiner already did the first commit for that, but 
some things still need to be discussed. 

Let's aim for the weekend!

Original comment by shuku...@gmail.com on 27 Oct 2011 at 9:07

GoogleCodeExporter commented 8 years ago
Weekend would be great, but no pressure :)
I'm not in a hurry, I was mostly curious.

Original comment by jitterja...@gmail.com on 27 Oct 2011 at 9:31