search

tedchou12 / webull

Unofficial APIs for Webull.
MIT License
597 stars 181 forks source link

Added Cryptobars function #288

Closed theafrocoder closed 2 years ago

theafrocoder commented 2 years ago

Hi,

Thanks for working on this project. It is awesome! I had the same issue as https://github.com/tedchou12/webull/issues/277 and made a "get_bars_crypto" function to fix this for me. This is my first time trying to give back some code so please forgive me if I didn't do something right.

Great work!

tedchou12 commented 2 years ago

@theafrocoder thanks for the contribution!! I really appreciate it!

The cryptobar looks great!

but the get_history_orders() doesn't seem to work... I tried to get the start_date from 11-08, but it returns old orders earlier than 11-08 as well like 11-04, how does this variable work?

theafrocoder commented 2 years ago

Thanks - glad it worked good. 

I was getting the same thing as you with the get_history_orders() - I'm not sure I did such a good job on that one.  Sorry I included into the pull by accident, I thought it worked at one point but I tried again today and it didn't work.  I got the same results as you.

On 11/08/2021 9:39 AM Ted ***@***.***> wrote:

@theafrocoderthanks for the contribution!! I really appreciate it! The cryptobar looks great! but the get_history_orders() doesn't seem to work... I tried to get the start_date from 11-08, but it returns old orders earlier than 11-08 as well like 11-04, how does this variable work? —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

tedchou12 commented 2 years ago

no worries, Thanks again!