search

tedchou12 / webull

Unofficial APIs for Webull.
MIT License
602 stars 185 forks source link

Added a "set did" function #371

Closed ICANTFINDAUSERNAMEATALL closed 1 year ago

ICANTFINDAUSERNAMEATALL commented 1 year ago

description already in code. this will allow new users to manually set their did.bin file to the did that they found from their browser.

I also added a function which converts a webull quote to a quote that can be used for the stock_indicators package. Link to the package here: https://github.com/DaveSkender/Stock.Indicators.Python

I'm not sure how many people will use this stock_indicators package so if anyone does use this package, separate installs(just pandas and stock_indicators via pip) will be needed for it to work. These packages won't be required for the api to work but will be required for convert_bars to work.

ICANTFINDAUSERNAMEATALL commented 1 year ago

I have 2 separate pull requests here but idk how to make them separate.

The first one adds a set_did function so that new people can set a did.

The second converts webull quote to a quote that can be used for the stock_indicators package. I'm not sure how many people will use this stock_indicators package so if anyone does use this package, separate installs(just pandas and stock_indicators via pip) will be needed for it to work. These packages won't be required for the api to work but will be required for convert_bars to work.

tedchou12 commented 1 year ago

@ICANTFINDAUSERNAMEATALL Thanks! I added the set_did, for the convert_bar, seems like it requires a new function, so dependencies also needs to be updated. I am not sure what is the necessity for this package? If it is used for indications instead, I think is better if we keep this library simple with the purpose to sort out:

I took a look at the library briefly, it looks like it is more an analytical tool? I think this would be more dependent on personal preferences and choices as well.

let me know if you have some other opinions!

Thanks again and Happy New Year!

ICANTFINDAUSERNAMEATALL commented 1 year ago

This convert_bar function is just to make the quotes from webull work with another package(stock_indicators). The library is more of an analytical tool so in reality, there is no API function of that. I think its reasonable to remove it if you think it doesn't add to the core of this API but I found the stock_indicators package to be really useful when algotrading.

Happy New Year!