search

tedconf / front_end_builds

Rails engine to manage front end builds and deployments
MIT License
75 stars 21 forks source link

Simplify handling of params #76

Closed nickcoyne closed 5 years ago

nickcoyne commented 8 years ago

Replace the version specific methods with something that will probably require less maintenance. And works for Rails 5.

nickcoyne commented 8 years ago

Builds are failing for Ruby 1.9.3 and 2.2.0. Looks like it may be gem dependency issues.

samselikoff commented 8 years ago

@ryanto I don't have commit access here

jhirbour commented 6 years ago

@samselikoff or @ryanto can you add me or @danbernier as a owner on RubyGems so we can push new versions of this gem up?

ryanto commented 6 years ago

Of course! I need your rubygems emails. I tried using your hirbour.org email, but it said user not found.

jhirbour commented 6 years ago

@ryanto just emailed you.

ryanto commented 6 years ago

Perfect, you're all set!

jhirbour commented 6 years ago

@nickcoyne once you resolve the merge conflicts, I'll get this merged and pushed to rubygems. Also make sure you bump the version number.

samselikoff commented 6 years ago

Just as an FYI – on my open-source repos I've started wiring up Travis to be able to publish new versions of our libs (npm, ruby gems). This way, we don't need to manage two sets of permissions. Anyone who has access to the Github repo can release/publish (since Travis is the one releasing).

Wanted to mention this because I really like the pattern and could help in the future.

nickcoyne commented 6 years ago

@jhirbour my last commit on this PR removed support for Rails < 5.0. Are you ok with that? I could probably do some more tidying up around that too.

jhirbour commented 6 years ago

@nickcoyne I'm discussing internally. I'll get back to you.

alexdean commented 5 years ago

@nickcoyne i need to update a FEB-using rails app to rails 5, & i'd like to get this PR merged & tagged & released. are you using this code currently? (tests are passing in travis, but not sure if that's sufficient or not.)

looks like the travis build matrix needs some cleanup (stop testing on rails versions < 5, probably update the set of rubies being tested against), and need some changelog notes. i'm happy to take that.

nickcoyne commented 5 years ago

@alexdean yes this code is currently in use on ed.ted.com (Rails 5.1)

gem 'front_end_builds',
    git: 'https://github.com/nickcoyne/front_end_builds.git',
    branch: 'simplify-rails-version-param-handling'
jozefvaclavik commented 5 years ago

I'm also running this branch on Rails 5.2. All good.

jhirbour commented 5 years ago

@nickcoyne I'm working on creating/tagging/pushing a release with these changes. I'll adjust the README accordingly. I'll also take a stab at fixing the travis bits too.

jhirbour commented 5 years ago

I've created this PR to incorporate Nick's changes into master. My PR also contains fixes for OpenSSL V2 which is used in Ruby 2.4 and greater.