Production builds should only contain production-ready builds

tedconf / front_end_builds

Rails engine to manage front end builds and deployments

MIT License

75 stars 21 forks source link

Production builds should only contain production-ready builds #77

Open janwerkhoven opened 8 years ago

janwerkhoven commented 8 years ago

We use front end builds for our production and staging environments. We were under false assumption that the list of production builds only contains builds which have been merged into the production branch. However it also seems to include feature branch builds that are pull requested to production. Because of this we accidentally activated a commit not yet ready for production and broke many things...

Is this as intended? Can we configure it? How can we prevent feature builds to appear in there?

samselikoff commented 8 years ago

All builds go to the builds table, this sounds like a problem that could be solved at the UI level with a new config option.

If we had a config option that let you limit the builds that show up in the table to a certain branch, so that the non-prod builds didn't show up in the table (and therefore they didn't show up in the admin table with the "Make live" button), would that solve the problem?

janwerkhoven commented 8 years ago

That would indeed help:

[ ] Per build in the FEB UI, show a label stating the Git branch name
[ ] Allow user to filter / show all builds belonging one particular Git branch

samselikoff commented 8 years ago

@janwerkhoven the admin already has the branch name, right? What version are you on?

Looking for help: A filter would be nice - the source of the Admin app is actually stored here. You can develop it like a normal Ember app.

The filtering functionality should only need to be added to the <build-list> component here. Think you'd be able to help with this feature?