search

teddykoker / torchsort

Fast, differentiable sorting and ranking in PyTorch
https://pypi.org/project/torchsort/
Apache License 2.0
765 stars 33 forks source link

Prebuilt release naming convention #73

Closed teddykoker closed 1 year ago

teddykoker commented 1 year ago

Align closer to the Wheel Naming Convention and torch's naming convention. For example the version built with torch 1.13, CUDA 11.7 and Python 3.10 would have the following name:

torchsort-0.1.9+pt113cu117-cp310-cp310-linux_x86_64.whl

teddykoker commented 1 year ago

@siddharthab just updated the naming convention to be a little more consistent. Let me know if you have any concerns, otherwise I think this is good for now, and I will run the release portion so the wheels are permanent.

siddharthab commented 1 year ago

This looks good. I have relatively little experience with the Python ecosystem, so I just put in something reasonable, but your format looks cleaner.

siddharthab commented 1 year ago

Also, maybe before you release, you may want to remove cuda 11.3 from the matrix. I was testing it for my own application and forgot to take it out before merging the PR but I don't think this project should support it.

teddykoker commented 1 year ago

Also, maybe before you release, you may want to remove cuda 11.3 from the matrix. I was testing it for my own application and forgot to take it out before merging the PR but I don't think this project should support it.

Done