search

tedhinklater / Jellyfin-Featured-Content-Bar

Featured Bar now with Fullscreen Version
GNU General Public License v3.0
46 stars 10 forks source link

Iframe protection #13

Closed PierreKy-org closed 1 day ago

PierreKy-org commented 3 days ago

Hello everyone,

I tried to intsall the featured content bar on my jellyfin container (https://hub.docker.com/r/linuxserver/jellyfin) and I have the banner.

But, as you can see, my browser block the content.

error

I tried with chrome too. I have the same issue

Do you have a way to solve this problem ?

Thanks a lot for your help !

tedhinklater commented 1 day ago

did you go to the spotlight.html page and download the file? Or did you possibly right-click the link and do Save Link ?

I've updated the guide to be a bit clearer.

PierreKy-org commented 1 day ago

Yes I can do it, do you want a pastebin of spotlight.html ?

tedhinklater commented 1 day ago

Instead of downloading spotlight.html I think a lot of people have been right-clicking the link to spotlight.HTML and using Save As...

This doesn't download spotlight.HTML but it downloads the github page for it.

A pastebin would be appreciated, to check

PierreKy-org commented 1 day ago

I know how to download the html file, I put in the good folder (/usr/share/jellyfin/web/ui/spotlight.html ) I put the API key inside and modify the home-html[numbers].chunk.js to integrate the iframe into the home page.

I don't think the issue it's from this part, it's more about CORS policy something like that

tedhinklater commented 1 day ago

Since the update it also needs List.txt in the ui folder

I've updated the guide, with a docker section

If your spotlight.html begins with <!DOCTYPE html><html lang="en" It's the wrong one. You need to download this one

spotlight.html

PierreKy-org commented 1 day ago

For the List.txt, I saw and add the file into my container.

Also this is my spotlight.html, I think it's good

image

Again, I can access to the file : https://mydomain.com/web/ui/spotlight.html but nothing appear. And same for the home page nothing appear

For the home page it's like the div doesn't exist :

image

PierreKy-org commented 1 day ago

I found the problem, it's my reverse proxy caddy, it had the X-Frame-Options as DENY and it blocked the content.

Perhaps we could add a warning in the README.md.

tedhinklater commented 1 day ago

ohhh you fixed it??

PierreKy-org commented 1 day ago

Yess, I ask for a #17 if it's ok for you

tedhinklater commented 1 day ago

that's a fantastic addition to the guide thank you so much, well done for figuring it out!