tedhinklater / finimalism

Jellyfin Theme CSS
GNU General Public License v3.0
94 stars 9 forks source link

New Update broke Skip Intro Button and also not completely a fan of moving every Button to the middle #13

Closed Mr3DAlien closed 3 days ago

Mr3DAlien commented 1 week ago

Screenshot 2024-11-09 172341

The newest update broke the new skip intro button. It worked before, but now it won't anymore. Already tried without the theme and then it worked again.

I am also not really a fan of moving every button in the middle of the screen. If it was up to me I wouldn't even like the play button in the middle. Please make it optional for people to choose which they prefer. I guess that this change also somehow made the skip intro button no longer work.

tedhinklater commented 1 week ago

Ok the repositioned buttons are put back. The Skip Intro button should be working, are you using JMP? It has to be enabled in Client Settings. Either way, the new/restored css is up, sorry about that

Mr3DAlien commented 6 days ago

Sorry I what exactly do you mean with JMP? I did have Ask to Skip enabled for everything. As soon as I did disable the theme the skip intro button reapears in videos. It seems to still not work for me. Your theme enabled removes it and your theme disabled enables it again. It did work before.

Also huge thanks for changing the buttons back :D

tedhinklater commented 6 days ago

hmmm ok I'll remove all the intro-skip stuff for now and try again, 10.10.x seems to have done more than I thought. Thanks for the info

edit: JMP as in Jellyfin Media Player. It should all be fixed now

Mr3DAlien commented 5 days ago

Ahh I understand. I use Jellyfin Web, but it still does not seem to work. I tried it on 3 different systems deleted the cache and everything, but it still only works with your theme disabled

Mr3DAlien commented 5 days ago

Do you not have any media that does contain an intro to test for yourself? You could add me on Discord if you need one

tedhinklater commented 5 days ago

Bizarre, let's check we're doing the same thing. Do you have intro-skipper plugin 1.10.10.7 installed and active?

If I disable my css, I get two skip intro buttons, one white and one blue. I think the blue one is the intro-skipper plugin (1.10.10.7, css is #skipIntro .emby-button) and the white one is something new in JF 10.10 (CSS is .skip-button)

I added .skip-button { display: none;} to hide the new white one, and only some code to change the colour of the plugin one.

Mr3DAlien commented 4 days ago

I run on Jellyfin 10.10.1 and have intro-skipper 10.10.6. I have the intro skipper plugin skip button disabled and set everything iny my web client to ask to skip. When enabling the custom CSS I can't see the skip button, but if I disable the CSS the skip button appears (white with rounded corners). I guess here is the problem, since you use the plugin one and removed the default one, where I want to use the default one and not the plugin one.

Mr3DAlien commented 4 days ago

Is there a reason I should use the plugin one over the default one? Because I would prefer the official one as it should work on more clients in the future like the firetv stick. I don't really understood why the skip plugin adds its own

tedhinklater commented 3 days ago

That makes sense, I've restored the white (official) one now. I'll also disable my plugin one if it's what everyone else will probably do. Thanks for the info :)

If you want to just add a line quickly to the bottom of your css box to add the fix it's

.skip-button { display: block !important; }

Thanks again

tedhinklater commented 3 days ago

the "block" fix looks a bit weird but the github one is normal, hopefully it updates soon fix

tedhinklater commented 3 days ago

It's updated