Add FT_PEEK in processStructure method

tedious / Fetch

An IMAP library for PHP

http://www.tedivm.com

Other

503 stars 158 forks source link

Add FT_PEEK in processStructure method #136

Closed Prestaspirit closed 9 years ago

Prestaspirit commented 9 years ago

Hi,

I just added FT_PEEK flag for the seen flag is not added automatically when calling the method processStructure while the message was not read

tomsommer commented 9 years ago

bjornpost commented 9 years ago

What's done is done I guess, but this PR being released in a minor release (0.7.x) really got me surprised as it's a big change from the behaviour of the method in previous releases. And made me wonder: does Fetch follow semver? And can we consider the API stable (thus requiring a major version when making backward incompatible changes)?

/cc: @tedivm

tedivm commented 9 years ago

@bjornpost you are 100% right and that was a mistake on my part.