jquery/jquery.validate.min.js file isn't getting minified properly.

[CGLOB]

[ pub/static/frontend/Magento/luma/en_US/jquery/jquery.validate.min.js ] is partially minified. It still contains parts without minifying.

Ex: If you scroll to the bottom, you will see a non minified part.

[CGLOB]

I have solve under jetbrains://php-storm/navigate/reference?project=magento2ce&path=~/Projects/JShrink/src/JShrink/Minifier.php file. but not able to create PR due permission issue. With my solution test passed as well attached the screenshot. [

](url)

[tedivm]

What permission issue are you getting trying to make a PR? This repository is open for pull requests.

[tedivm]

Is this the same issue we discussed in the PRs? Is it okay to close it now?

[CGLOB]

Is this the same issue we discussed in the PRs? Is it okay to close it now?

yes it is same issue. I am verifying with new version. If all good i will inform you the same.

[CGLOB]

Hi Robert, It is reproducible in latest version. Anyway i will create new PR https://github.com/tedious/JShrink/pull/124 with same solution along with test coverage as you suggested earlier. "To do that put a file named "regex_end_string.js" to-

./JShrink/tree/master/tests/Resources/jshrink/input/

And then add a second file with the expected output to-

./JShrink/tree/master/tests/Resources/jshrink/output/ "

[CGLOB]

Hi @tedivm any update about the PR? with my solution js is minifying properly.

[tedivm]

@CGLOB your PR has failing tests at the moment. If you can get those resolved I can give it a proper review.

[CGLOB]

@CGLOB your PR has failing tests at the moment. If you can get those resolved I can give it a proper review.

I need your help. regex_close.js output is not correct. The output need to be modified. My solution is related regex_close.js code which suppose to minify fully. It should be "function test(string){return(string||'').replace(/([\!"#$%&'()*+,./:;<=>?@[]^`{|}~])/g,'\$1')}". Your latest test code conflicting the solution. Your help will be much appreciated. and about Libraries:jquery_ui.js i am checking.

[CGLOB]

@tedivm I have fixed the issues and test passed as well. Can you please verify once.

[CGLOB]

@tedivm any update about PR https://github.com/tedious/JShrink/pull/124 review?

[tedivm]

I'm brainstorming some adversarial strings- basically I'm just trying to beat this up some more to make sure there are no regressions. Regex is one of the most annoying parts of processing, and I've made changes in the past that I thought were great that added in regressions. As a result I'm super paranoid about changes to that part of the code base.

[CGLOB]

I'm brainstorming some adversarial strings- basically I'm just trying to beat this up some more to make sure there are no regressions. Regex is one of the most annoying parts of processing, and I've made changes in the past that I thought were great that added in regressions. As a result I'm super paranoid about changes to that part of the code base.

Thanks a lot for the review and your input. Please let me know if i can or i must help you to solve the issue.