search

tedious / JShrink

Javascript Minifier built in PHP
http://www.tedivm.com
BSD 3-Clause "New" or "Revised" License
749 stars 152 forks source link

Is `echo` really needed? #121

Closed Enjoyzz closed 1 year ago

Enjoyzz commented 1 year ago

Is echo really needed here? there is already a concatenation $this->output.= $char;, and so buffering is removed, and now there is output and writing to the variable

https://github.com/tedious/JShrink/blob/8dd2fd54293e94fa1536c3c66700c707d814e043/src/JShrink/Minifier.php#L208

tedivm commented 1 year ago

Good call! I've got a PR up now to fix this- once tests pass I'll issue a bugfix release.

tedivm commented 1 year ago

Version v1.6.2 and higher will no longer echo- thanks for reporting!