Stash\Driver\* implement setOptions() as protected where public is expected

tedious / Stash

The place to keep your cache.

http://www.stashphp.com

BSD 3-Clause "New" or "Revised" License

961 stars 133 forks source link

Stash\Driver\* implement setOptions() as protected where public is expected #288

Closed ivarb closed 8 years ago

ivarb commented 8 years ago

The abstract class Stash\Driver\AbstractDriver defines setOptions() as public: public function setOptions(array $options = array()), therefore, child drivers should also implement this method as public. Otherwise, PHP Fatal errors could arise.

If making setOptions() protected is intended (it is according to the changelog), the abstract driver should also define it as protected.

version: 0.14.1

ivarb commented 8 years ago

My bad. Something with my IDE showing out-dated files.