tediousjs / node-mssql

Microsoft SQL Server client for Node.js
https://tediousjs.github.io/node-mssql
MIT License
2.23k stars 467 forks source link

chore(msnodesqlv8/request): remove superfluous arg #1408

Closed Fdawgs closed 2 years ago

Fdawgs commented 2 years ago

What this does:

Removes superfluous arg from castParameter() call. It only accepts two args:

https://github.com/tediousjs/node-mssql/blob/b9382d425726ecdaf29972e20e1c0e115cbd8856/lib/msnodesqlv8/request.js#L17

Related issues:

N/A

Pre/Post merge checklist:

Fdawgs commented 2 years ago

@dhensby mind taking a gander when you have a second, please?

dhensby commented 2 years ago

Sorry for the delay, I had seen this and did some investigation to check it was all ok but just forgot to merge it!

Fdawgs commented 2 years ago

Sorry for the delay, I had seen this and did some investigation to check it was all ok but just forgot to merge it!

Thanks, no need to apologise, we're all busy! Thanks for maintaining this and other repos my hospital uses!