search

tediousjs / node-mssql

Microsoft SQL Server client for Node.js
https://tediousjs.github.io/node-mssql
MIT License
2.22k stars 464 forks source link

perf: use `node:` prefix to bypass require.cache call for builtins #1550

Closed Fdawgs closed 10 months ago

Fdawgs commented 10 months ago

What this does:

Allows redundant require.cache calls to be bypassed for builtin modules, saving a few yoctoseconds.

See https://nodejs.org/api/modules.html#core-modules and discussion in nodejs/node repo regarding why require.cache calls are redundant for builtins.

Related issues:

N/A

Pre/Post merge checklist:

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 10.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dhensby commented 10 months ago

Nice, thanks. 🏃‍♂️