tediousjs / node-mssql

Microsoft SQL Server client for Node.js
https://tediousjs.github.io/node-mssql
MIT License
2.22k stars 464 forks source link

perf: remove unused regex capture groups #1551

Closed Fdawgs closed 10 months ago

Fdawgs commented 10 months ago

What this does:

Removes unused capture groups ( ) inside regex. A capture group is intended to store its matched text so it can be used later on e.g. in text replacements, so the regex engine has to do extra work every time a capture group is matched compared to a non-capture group. The captured text is never used elsewhere here.

Related issues:

N/A

Pre/Post merge checklist:

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 10.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dhensby commented 10 months ago

Thanks for these fixes 🎉