search

tediousjs / node-mssql

Microsoft SQL Server client for Node.js
https://tediousjs.github.io/node-mssql
MIT License
2.24k stars 471 forks source link

Fix README to document requirement for TCP/IP to be enabled in SQL Server #1651

Closed imjosh closed 5 months ago

imjosh commented 6 months ago

What this does:

Documents the requirement for TCP/IP to be enabled and provides instructions for enabling it

Related issues:

574

1649

Pre/Post merge checklist:

dhensby commented 6 months ago

Thanks for this.

I'm worried that these docs are much too specific for people installing and using a GUI/SQL server configuration manager.

I think all that is required is a comment that TCP/IP is required to be enabled on the SQL instance. This isn't docs for managing SQL servers (it's just a client) and this becomes maintenance overhead as the GUI/process changes. If there are official MS docs to link to, I'm happy with that, but not to link to unaffiliated 3rd parties.

PS same feedback as last PR regarding commit message 🙏

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 11.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: