search

tediousjs / tedious

Node TDS module for connecting to SQL Server databases.
http://tediousjs.github.io/tedious/
MIT License
1.58k stars 439 forks source link

ci: improve github actions #1573

Closed dhensby closed 3 months ago

dhensby commented 1 year ago
  1. The setup-node action automatically stores caches for NPM and uses the same logic as the current action implementation, so there's no need to duplicate it in the action definition.
  2. Remove redundant NPM upgrade step - v6.x of Node is no longer tested/supported.
  3. Linting step does not need complete repository history.
  4. Use setup-sqlserver action to install SQL Server
codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.25%. Comparing base (af21197) to head (9466826).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1573 +/- ## ======================================= Coverage 78.25% 78.25% ======================================= Files 93 93 Lines 4879 4879 Branches 937 937 ======================================= Hits 3818 3818 Misses 762 762 Partials 299 299 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arthurschreiber commented 3 months ago

@dhensby Would you mind resolving the conflicts with the latest changes that happened on master?

dhensby commented 3 months ago

@arthurschreiber done.

I had also wanted to replace lots of the repeated SQL Server installer code with the setup-sqlserver action, but I'm not sure it's an entirely 1-to-1 replacement

arthurschreiber commented 3 months ago

@dhensby It'd be great if setup-sqlserver would also fetch the latest updates - otherwise sql server 2022 is broken (TDS protocol version 8 does not work correctly).

dhensby commented 3 months ago

@arthurschreiber - working on it: https://github.com/tediousjs/setup-sqlserver/pull/45

arthurschreiber commented 3 months ago

I never quite understood why this didn't work out of the box. The installer has an option (UpdateEnabled) which defaults to true, and the default update source is MU (= Microsoft Update). 🤷

dhensby commented 3 months ago

I stopped trying to understand the SQL installer a long time ago! 😬

dhensby commented 3 months ago

@arthurschreiber looks like it's working, one of the tests hit a timeout and needs restarting

dhensby commented 3 months ago

🎉 we are green

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 18.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: