Open everhardt opened 7 months ago
Can you add tests for this change?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
57998f2
) 79.00% compared to head (b3b035c
) 78.08%.:exclamation: Current head b3b035c differs from pull request most recent head d704f1b. Consider uploading reports for the commit d704f1b to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you add tests for this change?
Done!
I got an
uncaughtException
, caused by trying to write a very large (negative) number using BulkLoad to a decimal column. Seems similar to https://github.com/tediousjs/tedious/issues/421. The stack trace I got:bulk-load:209 is inside the _tranform function, for which I think the following in the nodejs documentation holds:
Therefore, I propose to catch such errors and call the callback with it. I verified that solved my case.