Closed jtomaszewski closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.28%. Comparing base (
3856dc5
) to head (87dbc1a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @jtomaszewski, sorry for the long silence period on this PR. I have worked with @arthurschreiber , and made some change to this PR, and fix the failing tests. Please give a look, see if you ok with the changes. Hi @arthurschreiber, I found a way to get the change in here, not s smart way, but I think it works. Please take a look, see if this one is ok to be merged.
Awesome work, it looks great to me :)
:tada: This PR is included in version 18.4.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Currently when I run a DB procedure that requires a TVP input that has many columns and rows, if at least one value of that is incorrect (e.g. fails with a
The number NaN cannot be converted to a BigInt because it is not an integer
error), I only get that error message - without highlighting which param value is the faulty one. It looks like this:Finding the cause is very difficult then, I basically have to check every value 1-by-1 manually to see which one is wrong... or put a
debugger
into the tedious source code.This PR a bit improves that behaviour. If an error is thrown during the
generateParameterData
call, the error is wrapped, and its' message is kept, but also enhanced with information about which param is the wrong one.P.S. I can add some tests or change the implementation if you want, just let me know if you're okay with the general idea of doing this.