search

tediousjs / tedious

Node TDS module for connecting to SQL Server databases.
http://tediousjs.github.io/tedious/
MIT License
1.58k stars 439 forks source link

fix: error handling for domainToASCII #1608

Closed MichaelSun90 closed 3 months ago

MichaelSun90 commented 9 months ago

switch from punyCode to node:url introduce a behavior difference: https://github.com/tediousjs/tedious/pull/1597#issuecomment-1953027053

This fix the behavior.

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (afd3b54) to head (950385a).

Files Patch % Lines
src/sender.ts 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1608 +/- ## ========================================== + Coverage 79.00% 79.11% +0.10% ========================================== Files 93 93 Lines 4878 4879 +1 Branches 937 937 ========================================== + Hits 3854 3860 +6 + Misses 718 711 -7 - Partials 306 308 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MichaelSun90 commented 4 months ago

Hi @arthurschreiber, last time when we check this PR, you mentioned that description for this PR mentioned a test but it is missing from the changed files. I have went over the past commits, and I think we decided to remove the test since it seems the test is not needed. If you can give this PR a other look when you got time, see if we can merge this.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 18.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: