Open elliot-huffman opened 6 months ago
PR live! (rebuilt my branch to not be dependant.)
Thanks for putting all the effort to explain the background and make the PRs.
Would I be able to get you to review my pr?
I have looked into the PR and added some comments. Like I said on the PR side, will still be better to get feedback from @arthurschreiber.
Just added a learning link to the initial post.
Is your feature request related to a problem? If so, please give a short summary of the problem and how the feature would resolve it When coding on the project, the IDE was slowing me down a little because of the project's lack of IDE integration. Dev containers use deprecated configurations and out of date docker images. VS Code extension recommendations don't encompass the full capabilities of VS Code when doing dev for TypeScript. There is a generic password being used for the SA account in the dev container and test docker containers.
Describe the preferred solution I have created a GitHub workspace file with the configurations centralized. I have updated the recommended extension list to better match this project's configuration. I have randomized the password to reduce the bad practice of using non-random passwords for critical infrastructure. This does not change the fact that it is still hard coded, just trying to get better practices in place for everyone to follow.
I have a PR that I created and will submit it after the token credential (#1624) stuff is done because I accidentally made it a fork of the fork instead of the base project. Whoops :-P
I have tested the debug execution command and VS Code is able to pause the debugger inline on the typescript files.
Additional Learning https://code.visualstudio.com/docs/editor/workspaces