search

tediousjs / tedious

Node TDS module for connecting to SQL Server databases.
http://tediousjs.github.io/tedious/
MIT License
1.58k stars 439 forks source link

fix: rework connect timeout handling #1659

Closed arthurschreiber closed 2 months ago

arthurschreiber commented 2 months ago

Before submitting a PR :

  1. Ensure your fork is created from master branch of the repository.
  2. Run npm install in the root folder.
  3. After bug fix/code change, ensure all the existing tests and new tests (if any) pass (npm run-script test-all). During development, to run individual test use node_modules/nodeunit test/<test_file.js> -t <test_name>.
  4. Build the driver (npm run build).
  5. Run eslint and flow typechecker (npm run lint).
  6. Run commitlint (node_modules/.bin/commitlint --from origin/master --to HEAD). Refer commit conventions and commit rules.

Thank you for Contributing!

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 56.08466% with 83 lines in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (e8c6228) to head (b51bcbf). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/connection.ts 56.08% 74 Missing and 9 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1659 +/- ## ========================================== - Coverage 79.21% 79.14% -0.07% ========================================== Files 90 90 Lines 4855 4887 +32 Branches 929 930 +1 ========================================== + Hits 3846 3868 +22 - Misses 704 713 +9 - Partials 305 306 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arthurschreiber commented 2 months ago

Closing this in favor of #1663.