tedirghazali / codetube

Code Tube is source code from youtube videos
Apache License 2.0
33 stars 27 forks source link

covid19-world-map #4

Closed raidski20 closed 4 years ago

raidski20 commented 4 years ago

the data in covid19-world-map in index.js are static it was given, can you please make it dynamic by using an ipa because i tried to do it but i couldn't !

tedirghazali commented 4 years ago

Absolutely, right now I'm making timeline of covid19 with world map like wikipedia projection

Pada tanggal Rab, 22 Apr 2020 01.59, Raid Boulahdid < notifications@github.com> menulis:

the data in covid19-world-map in index.js is static it was given, can you please make it dynamic by using an ipa because i tried to do it but i couldn't !

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tedirghazali/codetube/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMYO4JU2JKY6LJVMPCWXETRNXUHPANCNFSM4MNQ7ORA .

raidski20 commented 4 years ago

Here is my js file i tried to make some modification in code to work with an ipa but it doesn't dipslay the data on the web page, feel free to read it and execute it to understand.

https://github.com/raid21/covid-map/blob/master/dataset-t.js

tedirghazali commented 4 years ago

You have to download mapael and raphael js plugins first, and then extract it to asset folder, get that plugin from this link github.com/neveldo/jQuery-Mapael also, use cdn instead, either jsdelivr or cdnjs, I have been seeing your project html and I found out your html file is missing the mapael plugin

Pada tanggal Rab, 22 Apr 2020 15.52, Raid Boulahdid < notifications@github.com> menulis:

Here is my index.js file i tried to make some modification in code to fit with an ipa but it doesn't dipslay the data on the web page, feel free to read it and execute it to understand.

https://github.com/raid21/covid-map/blob/master/dataset-t.js http://url

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tedirghazali/codetube/issues/4#issuecomment-617645417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMYO4POP3DE7QYG4LL2WULRN2V5TANCNFSM4MNQ7ORA .

raidski20 commented 4 years ago

I know and i did that it's just i didn't upload the full project, and i already integrated the mapael plugin using: i did everything and i don't get the result, here is the full project:

https://github.com/raid21/covid-map

tedirghazali commented 4 years ago

Also, you have to import its dependency, raphael.js, without this plugin, mapael won't work, import jquery mousewheel too, I will see your project again tomorow

Pada tanggal Rab, 22 Apr 2020 18.40, Raid Boulahdid < notifications@github.com> menulis:

I know and i did that it's just i didn't upload the full project, and i already integrated the mapael plugin using: <script src="asset/mapael/jquery.mapael.js"> i did everything and i don't get the result, here is the full project:

https://github.com/raid21/covid-map

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tedirghazali/codetube/issues/4#issuecomment-617725161, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMYO4IBJ7KBYN5POMPPEK3RN3JTDANCNFSM4MNQ7ORA .

tedirghazali commented 4 years ago

I already fork, edit and pull request your project, please merge it, I replace fetch with ajax, the problem is promise still pending when using async and await

Pada tanggal Rab, 22 Apr 2020 21.28, Tedir Ghazali tedirghazali@gmail.com menulis:

Also, you have to import its dependency, raphael.js, without this plugin, mapael won't work, import jquery mousewheel too, I will see your project again tomorow

Pada tanggal Rab, 22 Apr 2020 18.40, Raid Boulahdid < notifications@github.com> menulis:

I know and i did that it's just i didn't upload the full project, and i already integrated the mapael plugin using: <script src="asset/mapael/jquery.mapael.js"> i did everything and i don't get the result, here is the full project:

https://github.com/raid21/covid-map

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tedirghazali/codetube/issues/4#issuecomment-617725161, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMYO4IBJ7KBYN5POMPPEK3RN3JTDANCNFSM4MNQ7ORA .

raidski20 commented 4 years ago

It's done, now it's working fine. i had to use ajax and set additional param async to false to use the data outside the request.

https://github.com/raid21/covid-cases-world-map