search

tedleyem / react-themes

React Landing Page Themes
0 stars 0 forks source link

strip the word "treact" from all themes #8

Closed tedleyem closed 3 months ago

Sylar-codex commented 3 months ago

So what am I to replace them with? Or should I just leave them blank?

tedleyem commented 3 months ago

Replace the word with "placeholder" for now

Sylar-codex commented 3 months ago

Already stripped treact, but didn’t strip them from package.json and manifest.json. Did this to avoid any code breakage and also a url. So far went ahead to monitor the code to see if it’ll affect anything but it wont. But wanted to run that through you before finally taking the step to replace the entire thing. Although I’ve pushed some so far.

tedleyem commented 3 months ago

Strip it from everywhere and rebuild locally to confirm it doesn't break anything

Sylar-codex commented 3 months ago

Already pushed this, it broke at first but wasn’t due to the name, so had to update all packages in the package.json. Works good now.

tedleyem commented 3 months ago

If it's ready send a pull request

Sylar-codex commented 3 months ago

Created a PR

tedleyem commented 3 months ago

PR was approved and pushed