tednaleid / sublime-EasyMotion

Sublime Text 2 plugin to quickly jump to any character in the visible area of the active view.
Apache License 2.0
386 stars 24 forks source link

Escape appears to cancel but doesn't #40

Closed adamwathan closed 10 years ago

adamwathan commented 11 years ago

If you press cmd+; then a letter then decide to abandon what you were doing by pressing escape, all of the highlighted letters disappear but pressing a key still behaves as if you hadn't cancelled. Hitting escape multiple times induces some sort of weird undo-ish behavior.

This is on the st3 branch for reference.

pensierinmusica commented 10 years ago

+1

Currently on ST3 with EasyMotion installed, if you create a multiple selection (for example with ctr+cmd+g) and then press esc it doe not escape the selection.

Is EasyMotion still under development? Would it be possible to fix this bug?

Thanks!

tednaleid commented 10 years ago

development on the ST3 branch is currently in "hibernation" (though I'd accept pull requests). I don't really trust the sublime text developer to actually finish ST3 so I've been using ST2. It's been "in beta" for ~16 months now and has only had one beta release since June of last year (and nothing now for over 4 months).

I hope it's not dead, but I kind of fear that it is and I'm not interested in supporting it much further till they actually show that they're going to release the final version.

I'm actively supporting the ST2 version though.

pensierinmusica commented 10 years ago

Hi Ted, I understand your concerns, and it's easy to agree. On the other hand, doing some research online I found this: "Sublime Text 3 is not dead".

Would be cool if this bug could get fixed at some point, as the rest seem to already work pretty fine :)

tednaleid commented 10 years ago

This should be fixed by PR #48 haven't tested it personally as I don't use ST3, but the fix looked right to me, for those using ST3, let me know if this doesn't fix it and we can reopen

pensierinmusica commented 10 years ago

I tested it on ST3 and it does seem to work... awesome! :)