tedo0627 / RedstoneCircuit

This is the PocketMine plugin that implements the Redstone circuit.
GNU General Public License v3.0
84 stars 51 forks source link

Bugs #22

Closed DenielWorld closed 5 years ago

DenielWorld commented 5 years ago

All the bugs that I've found so far.

1: When a piston pushes another piston onto a different piston's arm server closes.

2: When a hopper has items in it, and gets pushed by a piston to be connected with a block that has an inventory, it does not transfer items.

3: If you take items out of the hopper while it is transferring them, the items get duped.

Most of these bugs can be critical for use on a server, please fix.

tedo0627 commented 5 years ago

I did not understand about 1 and 2. I'm glad if you send me an error log or a photo.

Bug 3 is a pmmp specification. Please try to proliferate in survival mode. When the player is in survival mode, it appears to multiply, but it is not.

DenielWorld commented 5 years ago

1 means that if a piston, pushes the second piston towards the third activated piston the server crashes.

2 means that if a hopper is moved by piston towards any block with inventory, it does not transfer items.

DenielWorld commented 5 years ago

Ill try what you said about 3

DenielWorld commented 5 years ago

Yes, 3 seems like a visual glitch. Although the other 2 bugs are real.

tedo0627 commented 5 years ago

After all I can not reproduce that state. I would be glad if you could send me a picture or video of that state.

DenielWorld commented 5 years ago

Do you have a email where I can provide the pictures?

DenielWorld commented 5 years ago

Sent

tedo0627 commented 5 years ago

ok

tedo0627 commented 5 years ago

I was able to confirm bug 1. I will fix it. But something like bug2 did not happen. I saw Item transferring from the hopper to the chest when I pull the lever. I will check just in case, is redstone plugin the latest?

DenielWorld commented 5 years ago

I believe so

tedo0627 commented 5 years ago

I fixed bug 1.

UladzimirPetrachkiu commented 5 years ago

When i place piston on piston (horizontal) i've got this error: "Call to undefined method redstone\blocks\BlockPistonarmcollision::getFace()" (EXCEPTION) in "plugins/RedstoneCircuit/src/redstone/blockEntities/BlockEntityPistonArm" at line 109. Because BlockPistonarmcollision haven't getFace() method. Please add some like in other piston blocks or something

public function getFace() : int {
    $damage = $this->getDamage();
    if ($damage == Facing::UP || $damage == Facing::DOWN) {
        return $damage;
    }
    return Facing::opposite($damage);
}
tedo0627 commented 5 years ago

I think fixed the bug, but has it not been fixed yet?

DenielWorld commented 5 years ago

What about 2?

DenielWorld commented 5 years ago

Piston bug still remains, I think the problem is that when a piston is pushed, it doesn't know what face side to set it to. So basically to fix that I think you should get the current face of the piston when it gets pushed by a different piston, and then set that face to the block that it gets moved to

DenielWorld commented 5 years ago

Bug 4> When an arrow out of dispenser hits an entity, server crashes (I guess the same thing will happen with any of the projectiles thrown by the dispenser)

tedo0627 commented 5 years ago

In the condition of the picture sent to me, I get no error. I'm glad if you send me a picture again under which condition an error occurs. I could not confirm bug2 and bug4. Please pull out plugins other than redstone plugin.

DenielWorld commented 5 years ago

For bug 4 you need to get the arrow of the dispenser to hit someone, as for bug 2 I am going to check again

tedo0627 commented 5 years ago

I tried on survival mode player and zombie but no errors occurred.

DenielWorld commented 5 years ago

I guess I could show you, could you get on my server?

tedo0627 commented 5 years ago

yes

tedo0627 commented 5 years ago

I am at your server now.

tedo0627 commented 5 years ago

I fixed the piston bug. Please check once.

DenielWorld commented 5 years ago

I see, ill take a look. Please fix the FactionsPE problem though.

tedo0627 commented 5 years ago

I fixed FactionsPE problem.

DenielWorld commented 5 years ago

Thank you

DenielWorld commented 5 years ago

Because of the factions fix dispensers cant do damage anymore